test: revamp eval related integration tests #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
yanxi0830
changed the title
yanxi0830
commented
Mar 6, 2025
| "role": "user", | ||
| "content": judge_input_msg, | ||
| } | ||
| UserMessage( |
There was a problem hiding this comment.
bug uncovered from unit tests :)
yanxi0830
changed the title
yanxi0830
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
raghotham,
sixianyi0721,
terrytangyuan and
vladimirivic
as code owners
ehhuang
approved these changes
Mar 6, 2025
ashwinb
reviewed
Mar 6, 2025
| prompt_template=sample_judge_prompt_template, | ||
| judge_score_regexes=[r"Score: (\d+)"], | ||
|
|
||
| scoring_fn = scoring_fns_list[0] |
There was a problem hiding this comment.
We test 1 scoring function per provider, as braintrust has 10+ scoring functions (each having multiple LLM calls), and its slow to loop over all.
Will look into having mocks for scoring as well s.t. running can be within reasonable time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
dataset
scoring
eval