Skip to content

Autocomplete search input broken in latest version #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hatsumatsu opened this issue Jul 15, 2024 · 2 comments
Closed

Autocomplete search input broken in latest version #352

hatsumatsu opened this issue Jul 15, 2024 · 2 comments

Comments

@hatsumatsu
Copy link
Contributor

hatsumatsu commented Jul 15, 2024

Describe the bug
After the latest updates, the experimental autocomplete search widget to connect posts is broken. When typing in the input field, no posts are shown.

To Reproduce
Steps to reproduce the behavior:

  1. Enable the experimental autocomplete inputs feature
  2. Edit a post
  3. Search for a post title in the connected sites
  4. No posts are returned

Environment (please complete the following information):

  • PHP Version 8.2
  • Plugin Version 2.8.1

Fix
After some debugging it seems that in the suggest() method, query vars are retrieved from the GET object, though the autocomplete request method ist POST.

public static function suggest() {

Switching from INPUT_GET to INPUT_POST in this method fixes the bug.

@lloc
Copy link
Owner

lloc commented Jul 22, 2024

It looks good to me. Please, send a PR.

@hatsumatsu
Copy link
Contributor Author

It looks good to me. Please, send a PR.

#353 here we go

@lloc lloc closed this as completed in 5411009 Aug 13, 2024
lloc added a commit that referenced this issue Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants