Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calyx] Add combinational trait. #1739

Closed
cgyurgyik opened this issue Sep 7, 2021 · 1 comment · Fixed by #1781
Closed

[Calyx] Add combinational trait. #1739

cgyurgyik opened this issue Sep 7, 2021 · 1 comment · Fixed by #1781
Labels
Calyx The Calyx dialect

Comments

@cgyurgyik
Copy link
Member

As mentioned by Rachit in #1735, it would be nice to have some combinational trait. Then, we could verify that only combinational cells (and eventually, instances of combinational components) are used within a combinational group.
@cgyurgyik cgyurgyik added the Calyx The Calyx dialect label Sep 7, 2021
@rachitnigam
Copy link
Contributor

Specifically, this would be for primitive definitions. Groups already have a CombGroup counterpart.

This was referenced Sep 12, 2021
Merged
Merged
cgyurgyik added a commit that referenced this issue Sep 14, 2021
@cgyurgyik
[Calyx] Add combinational trait. (#1781)
d599e6c 
This adds a combinational trait to Calyx operations. We can throw this on all non-memory operations for now, 
since they are all combinational. Eventually we'll need to split this off. Closes #1739. Also fixes a bug where it 
was considering a memory load as a store, since the address ports are used when both storing and loading to 
a MemoryOp. A test is added to verify this no longer occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Calyx The Calyx dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Calyx] Add combinational trait. llvm/circt
2 participants
@rachitnigam @cgyurgyik