[SeqToSV] Prepend RANDOMIZE-defining snippets #6882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be simpler to change the order at circt/lib/Conversion/SeqToSV/SeqToSV.cpp Line 416 in aca154a |
|
Actually, I don't think that prepend/append is the problem here, it's the fragments themselves that have to be shuffled around |
Fix an issue where the RANDOMIZE Verilog macro was used before it was defined. Co-authored-by: Nandor Licker <n@ndor.email> Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/fix-RANDOMIZE-undefined
branch
from
8ebe0e8 to
e60c1d6
Compare
|
You are entirely correct. Swapping the order gets things working and this fixes the observed internal bug. |
nandor
requested changes
Mar 30, 2024
|
Possible fix here: #6883 |
|
Closing in favor of #6683. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where the RANDOMIZE Verilog macro was used before it was
defined.