Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CombFolds] Preserve two-state attribute in narrowOperationWidth #7712

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

fzi-hielscher
Copy link
Contributor

We're already doing a best-effort preservation of discardable attributes through narrowOperationWidth. I cannot think of a reason why the inherent two-state attribute should not be carried over.

@fzi-hielscher fzi-hielscher marked this pull request as ready for review October 17, 2024 15:11
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fzi-hielscher fzi-hielscher merged commit 759b2b0 into llvm:main Oct 17, 2024
4 checks passed
@fzi-hielscher fzi-hielscher deleted the narrow-2state-aattr branch October 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants