Reject '<=' and 'is invalid' if FIRRTL version >=3 #7733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert tests to use "invalidate" and not "is invalid". The latter is supposed to be illegal in FIRRTL >=3. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Fix the parser to reject "is invalid" if the specified FIRRTL version is >= 3.0.0. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Get rid of usages of the deprecated '<=' connect syntax that is not supported in FIRRTL versions >=3. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Reject '<=' style FIRRTL connections if the FIRRTL version is 3 or higher. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/firrtl-3-parsing-checks
branch
from
b365dca
to
8235381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CIRCT's FIRRTL parser to reject statements which are supposed to be disallowed in FIRRTL 3.
Fixes #7731.