Use properties for attributes for many dialects #7736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the use of operation properties for more dialects in CIRCT. The option to *not* use properties is going to be removed in a future release of MLIR, but as well we expect this change to bring a performance improvement. For all these dialects, the only change required was to properly infer return types. Some operations were hardcoded to search through the attributes, and the attribute was moved to the property storage. By using the generated adaptor classes, we can abstract over where the interesting attribute is stored. For future work, some code may be refactored for further performance wins now that we are using properties. In particular usages `setAttr` and `getAttr` may be made faster by using a less generic op transformation interface.
youngar
force-pushed
the
firrtl-interface
branch
from
9ee5876
to
70f6c0f
Compare
youngar
requested review from
teqdruid,
mortbopet,
blakep-msft,
darthscsi,
Dinistro,
fabianschuiki,
maerhart,
seldridge,
rachitnigam,
cgyurgyik,
mikeurbach and
andrewb1999
as code owners
|
Updated to include all dialects but FIRRTL, it's going to take more work than everything else put together 😂 . I launched a full nightly integration test on this, just to be sure. It is running here. Testing this on a |
|
That's really impressive! |
|
I could've sworn we had this turned on for more dialects... I think our of the reasons you don't see more speedup is since it was already turned on for the comb and seq dialects. I suspect you'll see much more when you do this for the firrtl dialect. Thanks! |
seldridge
added a commit
that referenced
this pull request
Oct 28, 2024
Add a region verifier to OM dialect's Class Op. This verifies that the terminator returns the right number of fields with the correct types that match the declared type of the Class Op. Fixes #7736. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the use of operation properties for more dialects in CIRCT. The option to not use properties is going to be removed in a future release of MLIR, but as well we expect this change to bring a performance improvement.
For all these dialects, the only change required was to properly infer return types. Some operations were hardcoded to search through the attributes, and the attribute was moved to the property storage. By using the generated adaptor classes, we can abstract over where the interesting attribute is stored.
For future work, some code may be refactored for further performance wins now that we are using properties. In particular usages
setAttrandgetAttrmay be made faster by using a less generic op transformation interface.