[circt-test] Add simple SymbiYosys test runner #7756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
approved these changes
Oct 31, 2024
| @@ -0,0 +1,113 @@ | |||
| // RUN: circt-test %s -r circt-test-runner-sby.py | |||
| // REQUIRES: sby | |||
There was a problem hiding this comment.
Can you also run Filecheck to confirm all <num> tests passed is actually printed? (If it's tricky due to color I think it's ok not to add the check though).
There was a problem hiding this comment.
Ah cool idea, definitely!
| pm.addNestedPass<hw::HWModuleOp>(createLowerVerifToSVPass()); | ||
| pm.addNestedPass<hw::HWModuleOp>(sv::createHWLegalizeModulesPass()); | ||
| pm.addNestedPass<hw::HWModuleOp>(sv::createPrettifyVerilogPass()); | ||
| pm.addPass(createExportVerilogPass(verilogFile->os())); |
tools/circt-test/circt-test.cpp
Outdated
Comment on lines
248
to
249
| if (auto result = llvm::sys::findProgramByName(runner)) | ||
| runner = result.get(); |
There was a problem hiding this comment.
Good idea, thanks!
Extend circt-test to export the input MLIR file as Verilog and then run all discovered tests through a simple SymbiYosys runner script. This is currently very rigid: all tests are always run, and they all run through the exact same runner script. In the future, we'll want to add filtering mechanisms to include and exclude tests, and pick among multiple runner scripts for each test. Also add a basic integration test that builds an adder from discrete logic gates and then verifies it through multiple `verif.formal` ops. To run this you need to have SymbiYosys installed. In the future we'll want to have `circt-bmc` and other CIRCT-based verification tools available as runners as well.
fabianschuiki
force-pushed
the
fschuiki/circt-test-sby
branch
from
cfdef71
to
a1b66fb
Compare
|
Landing this since the only failure is related to #7093. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend circt-test to export the input MLIR file as Verilog and then run all discovered tests through a simple SymbiYosys runner script. This is currently very rigid: all tests are always run, and they all run through the exact same runner script. In the future, we'll want to add filtering mechanisms to include and exclude tests, and pick among multiple runner scripts for each test.
Also add a basic integration test that builds an adder from discrete logic gates and then verifies it through multiple
verif.formalops.To run this you need to have SymbiYosys installed. In the future we'll want to have
circt-bmcand other CIRCT-based verification tools available as runners as well.