[FIRRTL] ReplSeqMems: use the original mem name for the instance name #7776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When LowerMemories is replacing sequential memories with instances of extmodules, it uses the name of the of the generated extmodule as the name of the instance. This changes the pass to instead use the to use the original memory name + "_ext" for the instance of the extmodule. This mostly effects the instance name when a single extmodule was generated for two different memories with different names.
youngar
force-pushed
the
firrtl-mem-inst-name
branch
from
b703599
to
074d8e2
Compare
|
It is looking like we will be moving in this direction. Updated the PR with some test updates to pass CI. |
seldridge
reviewed
Nov 6, 2024
seldridge
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently more of an experiment, not sure if it is the direction we will go.