[FreezePaths] Add support for HWInstanceLike, instead of only HWInstanceOp #7778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngar
reviewed
Nov 6, 2024
Comment on lines
+171
to
+172
| auto mods = inst.getReferencedModuleNamesAttr(); | ||
| if (mods.size() > 1) |
There was a problem hiding this comment.
is it possible for the size to be 0?
There was a problem hiding this comment.
Interesting, I couldn't find any verifier that checks this. I think it should be illegal for an HWInstanceLike to have zero referenced modules. I will merge this as is, and create another PR to add the verifier.
youngar
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathVisitor::processPatherrors out on otherHWInstanceLikeoperations. But other dialects can add paths on such operations, handleHWInstanceLiketo support operations in other dialects.