Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Return an empty ArrayRef<Attr>, not an array of 1 attr #7779

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[FIRRTL] Return an empty ArrayRef<Attr>, not an array of 1 attr #7779

merged 1 commit into from
Nov 7, 2024

Conversation

rwy7
Copy link
Contributor

@rwy7 rwy7 commented Nov 7, 2024

No description provided.

@rwy7 rwy7 requested a review from youngar November 7, 2024 01:32
seldridge
seldridge approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though, I think this is correct because it is no longer returning a reference to a temporary.

@rwy7 rwy7 merged commit 05fd9c2 into llvm:main Nov 7, 2024
4 checks passed
@rwy7 rwy7 deleted the fix-get-layers branch November 7, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@youngar youngar Awaiting requested review from youngar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwy7 @seldridge