Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firtool] Run layer merge after inliner #7780

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

rwy7
Copy link
Contributor

@rwy7 rwy7 commented Nov 7, 2024

The inliner could create new opportunities to merge layers. Run layer merge afterwards, in order to merge more things.

@rwy7 rwy7 requested a review from seldridge November 7, 2024 17:07
@youngar youngar changed the title [FIRTOOL] Run layer merge after inliner [firtool] Run layer merge after inliner Nov 7, 2024
@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Nov 7, 2024
@rwy7 rwy7 requested a review from youngar November 7, 2024 19:35
Copy link
Member

@youngar youngar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an integration test for this

The inliner could create new opportunities to merge layers. Run layer merge
afterwards, in order to merge more things.
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwy7 rwy7 merged commit ef18fb8 into llvm:main Nov 7, 2024
4 checks passed
@rwy7 rwy7 deleted the inline-before-layer-merge branch November 7, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants