Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Emitting EICG wrapper warning only once #7785

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

prithayan
Copy link
Contributor

The EICG wrapper warning is be emitted unless the switchover to the intrinsic is made.
There are some designs where we have hundreds of clock gates, the warning clogs up the stdout for such cases.
This commit, ensures the warning is emitted only once.

Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/Dialect/FIRRTL/Transforms/LowerIntmodules.cpp Outdated Show resolved Hide resolved
@prithayan prithayan merged commit c511f66 into main Nov 12, 2024
4 checks passed
@prithayan prithayan deleted the dev/pbarua/eicg_warning branch November 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants