Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firtool] mv LoweLayers after CreateSiFiveMetadata #7794

Merged

Conversation

seldridge
Copy link
Member

Move the LowerLayers later in the firtool pass pipeline. This is working towards moving this pass to the end of the pipeline. This movement is a prerequisite to enable two features:

  1. Compilation of inline layers
  2. Forcing out of a layerblock

Move the `LowerLayers` later in the `firtool` pass pipeline.  This is
working towards moving this pass to the _end_ of the pipeline.  This
movement is a prerequisite to enable two features:

  1. Compilation of inline layers
  2. Forcing out of a layerblock

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Copy link
Contributor

@prithayan prithayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be good to go, once the PRs that update CreateSiFiveMetadata to support layers are merged.

@seldridge seldridge merged commit 3ba3993 into main Nov 12, 2024
4 checks passed
@seldridge seldridge deleted the dev/seldridge/LowerLayers-after-CreateSiFiveMetadata branch November 12, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants