[FIRRTL] Run canonicalizer again after IMCP #7796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
changed the title
IMCP propagates constants across modules, which should enable more canonicalization. However, lower-layers, which runs between IMCP and canonicalization, takes layerblocks and outlines them into their own module, which effectively undoes the work of IMCP, and prevents us from canonicalizing as well as we should under layers. This PR runs the canonicalizer immediately after IMCP, so that we have a better shot at canonicalization. In particular, we want to ensure that we are able to canonicalize away dead assertions and assumptions under layerblocks.
rwy7
force-pushed
the
canonicalize-after-imcp
branch
from
1a5eae9
to
4c322e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMCP propagates constants across modules, which should enable more
canonicalization. However, lower-layers, which runs between IMCP and
canonicalization, takes layerblocks and outlines them into their own module.
This effectively undoes the work of IMCP, and prevents us from canonicalizing
as well as we should under layers. This PR adds an additional run of the canonicalizer
immediately after the second run of IMCP, so that we have a better shot at
canonicalization.
In particular, we want to ensure that we are able to canonicalize away dead
assertions and assumptions under layerblocks.