[firtool] Run CSE on classes #7814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runs CSE on all operations underneath the circuit. This also moves it up before the rest of the FModule passes run, as the Any pipeline will not merge with them.
seldridge
approved these changes
Nov 14, 2024
Comment on lines
-68
to
-70
| if (!opt.shouldDisableOptimization()) | ||
| pm.nest<firrtl::CircuitOp>().nest<firrtl::FModuleOp>().addPass( | ||
| mlir::createCSEPass()); |
There was a problem hiding this comment.
Is there any benefit in running twice or keeping this here to run on FModuleOp? Or: is CSE blocked on things with different names / does DropNames expose work for CSE?
There was a problem hiding this comment.
Should be OK I think. CSE will only remove the ops marked Pure, and anything FNamable is not Pure.
|
@uenoku I merged this as is, but I agree with what you said offline: it seems like it would be a great idea to push this as far to the front of the pipeline as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs CSE on all operations underneath the circuit. This also moves it up before the rest of the FModule passes run, as the Any pipeline will not merge with them.