Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Handshake][Python] Add Python bindings for Handshake #7846

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[Handshake][Python] Add Python bindings for Handshake #7846

merged 2 commits into from
Nov 21, 2024

Conversation

teqdruid
Copy link
Contributor

No description provided.

@teqdruid teqdruid added Handshake Python Python bindings labels Nov 19, 2024
@teqdruid
Copy link
Contributor Author

This one was odd since the Handshake tablegen/printer/parser are still in an old style and missing features. I don't want to go down the rat hole of touching the internals, which would be necessary to clean this up.

Dinistro
Dinistro approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Dinistro Dinistro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the python bindings, but given that the test passes, this is probably fine 😅 .

mikeurbach
mikeurbach approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I did one of these, but it looks good to me.

@teqdruid
Minor enhancements for handshake.py
24beabf 
Changes made in PyCDE bindings
@teqdruid teqdruid merged commit ef98c93 into main Nov 21, 2024
4 checks passed
@teqdruid teqdruid deleted the teqdruid/handshake-python branch November 21, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinistro Dinistro Dinistro approved these changes

@mikeurbach mikeurbach mikeurbach approved these changes

@mortbopet mortbopet Awaiting requested review from mortbopet mortbopet is a code owner

Assignees
No one assigned
Labels
Handshake Python Python bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teqdruid @mikeurbach @Dinistro