[FIRRTL] Dedup: dedup private modules into public ones #7877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
approved these changes
Nov 22, 2024
seldridge
approved these changes
Nov 22, 2024
Comment on lines
-1708
to
-1709
| if (!checkVisibility(module)) | ||
| return success(); |
There was a problem hiding this comment.
Something to keep an eye on: now that there is no early exit here, all modules will be hashed. This may affect performance, specifically for private classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows private modules to deduplicate in to public modules. It does this by swapping a private canonical module with a public module when found. Future public modules will not deduplicate into this group, as public modules can not dedup with other public modules in general. This also begins ignoring the convention of private modules, as it doesn't really carry any meaning. In the future we might want to disallow conventions to be specified on private modules.