Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Verif] Require a clock when num_regs is non-zero on a BMC op #7891

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Verif] Require a clock when num_regs is non-zero on a BMC op #7891

merged 1 commit into from
Nov 25, 2024

Conversation

TaoBi22
Copy link
Contributor

@TaoBi22 TaoBi22 commented Nov 25, 2024

This adds a verification requirement that if a BoundedModelCheckingOp has a non-zero num_regs attribute, there must be a clock in the circuit region's arguments (to clock the registers with).

@TaoBi22 TaoBi22 requested a review from maerhart November 25, 2024 15:00
maerhart
maerhart approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@TaoBi22 TaoBi22 merged commit 83b5ff3 into llvm:main Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maerhart maerhart maerhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaoBi22 @maerhart