[FIRRTL] FoldUnusedBits: minor cleanup #7914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the memory has been replaced with the compressed memory, a lot of the bitselect ops reading from the old memory will be selecting the entire memory. Use createOrFold to eagerly clean up these "whole range bitselect" ops.
rwy7
requested review from
youngar and
seldridge
and removed request for
seldridge
seldridge
approved these changes
Nov 27, 2024
Comment on lines
-2694
to
+2695
| if (!bits) { | ||
| usedBits.set(); | ||
| continue; | ||
| } | ||
| if (!bits) | ||
| return failure(); |
There was a problem hiding this comment.
This early exit makes sense to me. No reason to wait until all users have been visited before bailing.
Comment on lines
-2831
to
+2841
| rewriter.replaceOpWithNewOp<BitsPrimOp>( | ||
| readOp, readOp.getInput(), | ||
| // Create a new bit selection from the compressed memory. The new op may | ||
| // be folded if we are selecting the entire compressed memory. | ||
| auto newReadValue = rewriter.createOrFold<BitsPrimOp>( | ||
| readOp.getLoc(), readOp.getInput(), | ||
| readOp.getHi() - readOp.getLo() + it->second, it->second); | ||
| rewriter.replaceAllUsesWith(readOp, newReadValue); | ||
| rewriter.eraseOp(readOp); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes: