[RTG] Add set union operation #7916
Conversation
| Computes the union of the given sets. If the list of sets must contain at | ||
| least one element. |
There was a problem hiding this comment.
Does the second sentence want to say "The list of sets must contain at least one element."? If yes, it might be worth checking for that in the verifier, or if empty sets are valid, maybe just return an empty set in that case?
There was a problem hiding this comment.
Yes that's what it should say. It originally said that if there are zero operands, it returns the empty set but then changed it because the SameOperandsAndResultType trait verifies that there is at least one operand (there is also a test for that already added). We could go back to allowing zero operands, but I'm not sure it it's beneficial (it would just fold to a zero-operand set_create).
There was a problem hiding this comment.
Oh nice! I was wondering where the error message came from 😀 No need to change anything, disallowing empty operand lists feels very reasonable. Especially since you'd have two different ways of creating a constant empty set otherwise, which would be pretty weird.
maerhart
force-pushed
the
maerhart-rtg-register-interface
branch
from
6990196 to
f5204eb
Compare
maerhart
changed the base branch from
maerhart-rtg-register-interface
to
main
maerhart
force-pushed
the
maerhart-rtg-set-union
branch
from
2bf1d4d to
d4c18d8
Compare
maerhart
force-pushed
the
maerhart-rtg-set-union
branch
from
d4c18d8 to
f61ea9d
Compare
maerhart
force-pushed
the
maerhart-rtg-set-union
branch
from
f61ea9d to
9e4d714
Compare
No description provided.