[CIR][Lowering] Add long double types for cos operation lowering (#568)

Add left long double types lowering for cos operation #565 --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
llvm · Apr 29, 2024 · 666246b · 666246b
1 parent bc7bf51
commit 666246b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 14 deletions.
diff --git a/clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp b/clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp
@@ -167,10 +167,8 @@ class CIRConstantOpLowering
       auto boolValue = mlir::cast<mlir::cir::BoolAttr>(op.getValue());
       value = rewriter.getIntegerAttr(ty, boolValue.getValue());
     } else if (op.getType().isa<mlir::cir::CIRFPTypeInterface>()) {
-      assert(ty.isF32() || ty.isF64() && "NYI");
       value = rewriter.getFloatAttr(
-          typeConverter->convertType(op.getType()),
-          op.getValue().cast<mlir::cir::FPAttr>().getValue());
+          ty, op.getValue().cast<mlir::cir::FPAttr>().getValue());
     } else {
       auto cirIntAttr = mlir::dyn_cast<mlir::cir::IntAttr>(op.getValue());
       assert(cirIntAttr && "NYI non cir.int attr");
@@ -664,6 +662,12 @@ static mlir::TypeConverter prepareTypeConverter() {
   converter.addConversion([&](mlir::cir::DoubleType type) -> mlir::Type {
     return mlir::FloatType::getF64(type.getContext());
   });
+  converter.addConversion([&](mlir::cir::FP80Type type) -> mlir::Type {
+    return mlir::FloatType::getF80(type.getContext());
+  });
+  converter.addConversion([&](mlir::cir::LongDoubleType type) -> mlir::Type {
+    return converter.convertType(type.getUnderlying());
+  });
   converter.addConversion([&](mlir::cir::ArrayType type) -> mlir::Type {
     auto elementType = converter.convertType(type.getEltType());
     return mlir::MemRefType::get(type.getSize(), elementType);

diff --git a/clang/test/CIR/Lowering/ThroughMLIR/cos.cir b/clang/test/CIR/Lowering/ThroughMLIR/cos.cir
@@ -5,18 +5,26 @@ module {
   cir.func @foo() {
     %1 = cir.const(#cir.fp<1.0> : !cir.float) : !cir.float
     %2 = cir.const(#cir.fp<1.0> : !cir.double) : !cir.double
-    %3 = cir.cos %1 : !cir.float
-    %4 = cir.cos %2 : !cir.double
+    %3 = cir.const(#cir.fp<1.0> : !cir.long_double<!cir.f80>) : !cir.long_double<!cir.f80>
+    %4 = cir.const(#cir.fp<1.0> : !cir.long_double<!cir.double>) : !cir.long_double<!cir.double>
+    %5 = cir.cos %1 : !cir.float
+    %6 = cir.cos %2 : !cir.double
+    %7 = cir.cos %3 : !cir.long_double<!cir.f80>
+    %8 = cir.cos %4 : !cir.long_double<!cir.double>
     cir.return
   }
 }
 
-//CHECK: module {
-//CHECK:   func.func @foo() {
-//CHECK:     %cst = arith.constant 1.000000e+00 : f32
-//CHECK:     %cst_0 = arith.constant 1.000000e+00 : f64
-//CHECK:     %0 = math.cos %cst : f32
-//CHECK:     %1 = math.cos %cst_0 : f64
-//CHECK:     return
-//CHECK:   }
-//CHECK: }
+// CHECK:      module {
+// CHECK-NEXT:   func.func @foo() {
+// CHECK-NEXT:     %[[C0:.+]] = arith.constant 1.000000e+00 : f32
+// CHECK-NEXT:     %[[C1:.+]] = arith.constant 1.000000e+00 : f64
+// CHECK-NEXT:     %[[C2:.+]] = arith.constant 1.000000e+00 : f80
+// CHECK-NEXT:     %[[C3:.+]] = arith.constant 1.000000e+00 : f64
+// CHECK-NEXT:     %{{.+}} = math.cos %[[C0]] : f32
+// CHECK-NEXT:     %{{.+}} = math.cos %[[C1]] : f64
+// CHECK-NEXT:     %{{.+}} = math.cos %[[C2]] : f80
+// CHECK-NEXT:     %{{.+}} = math.cos %[[C3]] : f64
+// CHECK-NEXT:     return
+// CHECK-NEXT:   }
+// CHECK-NEXT: }