[CIR][Lowering] Add MLIR lowering support for CIR cos operations #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhoujing <jing.zhou@terapines.com>
Signed-off-by: zhoujing <jing.zhou@terapines.com>
bcardosolopes
approved these changes
Apr 25, 2024
| @@ -153,6 +166,11 @@ class CIRConstantOpLowering | |||
| if (mlir::isa<mlir::cir::BoolType>(op.getType())) { | |||
| auto boolValue = mlir::cast<mlir::cir::BoolAttr>(op.getValue()); | |||
| value = rewriter.getIntegerAttr(ty, boolValue.getValue()); | |||
| } else if (op.getType().isa<mlir::cir::CIRFPTypeInterface>()) { | |||
| assert(ty.isF32() || ty.isF64() && "NYI"); | |||
There was a problem hiding this comment.
I missed this before I merged. During the lowering passes, you should return mlir::failure() for these instead, since it provides a more clean error message. If you could address that in another PR it'd be great.
There was a problem hiding this comment.
OK, @bcardosolopes I will do that in next PR
bcardosolopes
pushed a commit
that referenced
this pull request
Apr 26, 2024
Add left long double types lowering for cos operation #565 --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
#563 This PR add cir.cos lowering to MLIR math dialect, now it only surpport single and double float types, I add an assertation for the long double and other unimplemented types --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Add left long double types lowering for cos operation #565 --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
#563 This PR add cir.cos lowering to MLIR math dialect, now it only surpport single and double float types, I add an assertation for the long double and other unimplemented types --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Add left long double types lowering for cos operation #565 --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
#563 This PR add cir.cos lowering to MLIR math dialect, now it only surpport single and double float types, I add an assertation for the long double and other unimplemented types --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Add left long double types lowering for cos operation #565 --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
#563 This PR add cir.cos lowering to MLIR math dialect, now it only surpport single and double float types, I add an assertation for the long double and other unimplemented types --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Add left long double types lowering for cos operation #565 --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#563 This PR add cir.cos lowering to MLIR math dialect, now it only surpport single and double float types, I add an assertation for the long double and other unimplemented types