Can I try to make a lowering operation for cir.cos? #563

zhoujingya · 2024-04-24T07:21:08Z

Hello, I am newer for cir, and now I find many cir operations which are desired to be lowered to mlir are still not implemented yet, my first intention was lowering cir.cos to math.cos, but I am not sure it is ok or not

Lancern · 2024-04-25T01:52:51Z

my first intention was lowering cir.cos to math.cos, but I am not sure it is ok or not

That looks reasonable. You can always draft a PR and the community can give more solid feedbacks.

#563 This PR add cir.cos lowering to MLIR math dialect, now it only surpport single and double float types, I add an assertation for the long double and other unimplemented types --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>

…m#565) llvm#563 This PR add cir.cos lowering to MLIR math dialect, now it only surpport single and double float types, I add an assertation for the long double and other unimplemented types --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>

#563 This PR add cir.cos lowering to MLIR math dialect, now it only surpport single and double float types, I add an assertation for the long double and other unimplemented types --------- Signed-off-by: zhoujing <jing.zhou@terapines.com>

zhoujingya mentioned this issue Apr 25, 2024

[CIR][Lowering] Add MLIR lowering support for CIR cos operations #565

Merged

zhoujingya closed this as completed Apr 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can I try to make a lowering operation for cir.cos? #563

Can I try to make a lowering operation for cir.cos? #563

zhoujingya commented Apr 24, 2024 •

edited

Loading

Lancern commented Apr 25, 2024

Can I try to make a lowering operation for cir.cos? #563

Can I try to make a lowering operation for cir.cos? #563

Comments

zhoujingya commented Apr 24, 2024 • edited Loading

Lancern commented Apr 25, 2024

zhoujingya commented Apr 24, 2024 •

edited

Loading