Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb-dap] Enabling instruction breakpoint support to lldb-dap. #105278

Merged
merged 75 commits into from
Aug 26, 2024

Commits on Nov 17, 2023

  1. [lldb][test] Add the ability to extract the variable value out of the…

    … summary.
    Santhosh Kumar Ellendula committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    960351c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    94c7680 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    3235090 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff9077f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa762d2 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    09ff158 View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Added "port" property to vscode "attach" command.

    Adding a "port" property to the VsCode "attach" command likely extends the functionality of the debugger configuratiuon to allow attaching to a process using PID or PORT number.
    Currently, the "Attach" configuration lets the user specify a pid. We tell the user to use the attachCommands property to run "gdb-remote <port>".
    Followed the below conditions for "attach" command with "port" and "pid"
    We should add a "port" property. If port is specified and pid is not, use that port to attach. If both port and pid are specified, return an error saying that the user can't specify both pid and port.
    
    Ex - launch.json
    {
    	"version": "0.2.0",
        "configurations": [
            {
                "name": "lldb-dap Debug",
                "type": "lldb-dap",
                "request": "attach",
                "port":1234,
                "program": "${workspaceFolder}/a.out",
                "args": [],
                "stopOnEntry": false,
                "cwd": "${workspaceFolder}",
                "env": [],
    
            }
        ]
    }
    Santhosh Kumar Ellendula committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ab44a69 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef4f016 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    35ba7f7 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    bd38f88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f65a580 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5763225 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bb18d6d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1b1ae2b View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Configuration menu
    Copy the full SHA
    a2e4580 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3795dcd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    628fa40 View commit details
    Browse the repository at this point in the history
  4. [lldb-dap] Added "port" property to vscode "attach" command.

    Adding a "port" property to the VsCode "attach" command likely extends the functionality of the debugger configuration to allow attaching to a process using PID or PORT number.
    Currently, the "Attach" configuration lets the user specify a pid. We tell the user to use the attachCommands property to run "gdb-remote ".
    Followed the below conditions for "attach" command with "port" and "pid"
    We should add a "port" property. If port is specified and pid is not, use that port to attach. If both port and pid are specified, return an error saying that the user can't specify both pid and port.
    
    Ex - launch.json
    {
    "version": "0.2.0",
    "configurations": [
    {
    "name": "lldb-dap Debug",
    "type": "lldb-dap",
    "request": "attach",
    "port":1234,
    "program": "${workspaceFolder}/a.out",
    "args": [],
    "stopOnEntry": false,
    "cwd": "${workspaceFolder}",
    "env": [],
    
        }
    ]
    }
    
    In this patch we have resolved code formatting issues and fixed "test_by_name" failure.
    Santhosh Kumar Ellendula committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4e2e524 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    4774f58 View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Added "port" property to vscode "attach" command.

    Resolved code format issues.
    Santhosh Kumar Ellendula committed May 9, 2024
    Configuration menu
    Copy the full SHA
    175f1d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a6e9f66 View commit details
    Browse the repository at this point in the history
  4. Resolved code format issue.

    Santhosh Kumar Ellendula committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e5c0aed View commit details
    Browse the repository at this point in the history
  5. Resolved code format errors.

    Santhosh Kumar Ellendula committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c502203 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    89800a8 View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Added "port" property to vscode "attach" command - Address…

    …ed review comments
    
    Addressed all review comments.
    Santhosh Kumar Ellendula committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c1bf2bd View commit details
    Browse the repository at this point in the history
  3. [lldb-dap] Added "port" property to vscode "attach" command - fix cod…

    …e format
    
    resolved code format issues.
    Santhosh Kumar Ellendula committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5590afc View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    afcce33 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    281c281 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    624b789 View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Added "port" property to vscode "attach" command - resolve…

    …d all review comments.
    
    All review comments have been addressed, and the attach-by-port tests have been verified on
    Linux machine. Although the functionality is intended to support both Linux and macOS, we were
    unable to verify it on macOS due to lack of access.
    Santhosh Kumar Ellendula committed May 28, 2024
    Configuration menu
    Copy the full SHA
    023b51e View commit details
    Browse the repository at this point in the history
  3. [lldb-dap] Added "port" property to vscode "attach" command -resolved…

    … format check issues.
    Santhosh Kumar Ellendula committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d19eb88 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    16c37cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    599a5ca View commit details
    Browse the repository at this point in the history
  3. [lldb-dap] Added "port" property to vscode "attach" command. llvm#91570

    Resolved few review commennts.
    Santhosh Kumar Ellendula committed May 30, 2024
    Configuration menu
    Copy the full SHA
    fe9a4b6 View commit details
    Browse the repository at this point in the history
  4. [lldb-dap] Added "port" property to vscode "attach" command.

    Resolved code format issues.
    Santhosh Kumar Ellendula committed May 30, 2024
    Configuration menu
    Copy the full SHA
    c91b02d View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    35ad541 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e3f3a5 View commit details
    Browse the repository at this point in the history
  3. [lldb-dap] Added "port" property to vscode "attach" command - address…

    …ed review comments.
    
    Used named pipe to read debug server listening port.
    Since we are only using "gdb-remote" process plugin, changed to "gdb-remote-port" and
    "gdb-remote-hostname" from "port" and "hostname"
    Santhosh Kumar Ellendula committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    de29728 View commit details
    Browse the repository at this point in the history
  4. [lldb-dap] Added "port" property to vscode "attach" command - resolve…

    …d code format issues.
    Santhosh Kumar Ellendula committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ac84b53 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    7d1319c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    2a0eb9d View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Added "port" property to vscode "attach" command - fixed …

    …review comments.
    Santhosh Kumar Ellendula committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    08f40aa View commit details
    Browse the repository at this point in the history
  3. [lldb-dap] Added "port" property to vscode "attach" command - resolve…

    …d review comments.
    Santhosh Kumar Ellendula committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2a0bc63 View commit details
    Browse the repository at this point in the history
  4. [lldb-dap] Added "port" property to vscode "attach" command.

    I have shifted "Pipe" class to common location "lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py"
    Santhosh Kumar Ellendula committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    656c34a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    673ae34 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    c6e552a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    043895d View commit details
    Browse the repository at this point in the history
  3. [lldb-dap] Updated README.md for newly added attach properties.

    Added "gdb-remote-port" and "gdb-remote-hostname" attach properties usage in
    README.md.
    
    This was missed in PR llvm#91570
    Santhosh Kumar Ellendula committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    fe36e25 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    2011cb5 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    03e4c20 View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Updated README.md for newly added attach properties. llvm#…

    …99926
    
    Corrected spelling mistakes.
    Santhosh Kumar Ellendula committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    10d16b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Configuration menu
    Copy the full SHA
    a6c4895 View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Bump the version to 0.2.3

    Bump the lldb-dap version to 0.2.3.
    Santhosh Kumar Ellendula committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    58affe7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    033c6a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    7c96402 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    17a99a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    1e7d5f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    e6fa6a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    5069297 View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Added support for "supportsInstructionBreakpoints" capability and now it this command is triggered when we set instruction breakpoint.
    We need this support as part of enabling disassembly view debugging. Following features should work as part of this feature enablement:
    
    1. Settings breakpoints in disassembly view: Unsetting the breakpoint is not happening from the disassembly view. Currently we need to unset breakpoint manually from the breakpoint List. Multiple breakpoints are getting set for the same $
    
    2. Step over, step into, continue in the disassembly view
    
    The format for DisassembleRequest and DisassembleResponse at https://raw.githubusercontent.com/microsoft/vscode/master/src/vs/workbench/contrib/debug/common/debugProtocol.d.ts .
    santhoshe447 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7e22182 View commit details
    Browse the repository at this point in the history
  3. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Resolved code format issues.
    santhoshe447 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ffe8dbc View commit details
    Browse the repository at this point in the history
  4. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Resolved code format issues.
    santhoshe447 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4d87a93 View commit details
    Browse the repository at this point in the history
  5. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    The following changes were committed by mistake, so they have been reverted.
    "startDebugging", &g_dap.start_debugging_request_handler,
    "repl-mode", &g_dap.repl_mode_request_handler,
    santhoshe447 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    18bcb03 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Few changes were missed in lldb/tools/lldb-dap/DAP.h, so added in this version.
    santhoshe447 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9893985 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Resolved review comments.
    santhoshe447 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e0101c1 View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Added stop reason for instruction breakpoint.
    santhoshe447 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    17f8c6d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8c19498 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5031df9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Configuration menu
    Copy the full SHA
    27d668f View commit details
    Browse the repository at this point in the history
  2. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Resolved follwoing review comments :
    1. Removed usage of removed_ibp, removed deleted instruction breakpoints deirectly from g_dap.instruction_breakpoints.erase(prev_ibp.first)
    2. Reused CreateJsonObject function in CreateInstructionBreakpoint.
    3. Updated test cases with stop reason.
    santhoshe447 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    dbad4c5 View commit details
    Browse the repository at this point in the history
  3. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Resolved code format issues.
    santhoshe447 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bac086e View commit details
    Browse the repository at this point in the history
  4. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Resolved review comments.
    santhoshe447 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5401fbe View commit details
    Browse the repository at this point in the history
  5. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Resolved review comments.
    santhoshe447 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3523cef View commit details
    Browse the repository at this point in the history
  6. [lldb-dap] Enabling instruction breakpoint support to lldb-dap.

    Resolved review comments.
    santhoshe447 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ab68b22 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc30dd1 View commit details
    Browse the repository at this point in the history