Skip to content

llvm-reduce: Fix losing fast math flags in operands-to-args #133421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 28, 2025

No description provided.

@regehr
Copy link
Contributor

regehr commented Mar 28, 2025

LGTM

@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-callsite-attrs-operands-to-args branch from 1e43812 to 20a68d2 Compare March 28, 2025 16:31
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-fmf-operands-to-args branch from 6d55981 to a59ef1f Compare March 28, 2025 16:32
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-callsite-attrs-operands-to-args branch from 20a68d2 to 08e5a78 Compare March 28, 2025 16:44
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-fmf-operands-to-args branch from a59ef1f to 1ef46ec Compare March 28, 2025 16:45
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-callsite-attrs-operands-to-args branch from 08e5a78 to c1eeec8 Compare March 28, 2025 16:53
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-fmf-operands-to-args branch from 1ef46ec to f7605ba Compare March 28, 2025 16:53
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-callsite-attrs-operands-to-args branch from c1eeec8 to 97940dd Compare March 28, 2025 17:02
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-fmf-operands-to-args branch from f7605ba to d102bc1 Compare March 28, 2025 17:03
@aeubanks
Copy link
Contributor

can we have a CallInst copy all flags/metadata helper function?

@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-fmf-operands-to-args branch from d102bc1 to 02186b9 Compare March 29, 2025 03:05
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-callsite-attrs-operands-to-args branch from 97940dd to 181a168 Compare March 29, 2025 03:05
@arsenm
Copy link
Contributor Author

arsenm commented Mar 29, 2025

can we have a CallInst copy all flags/metadata helper function?

Mostly could. The attribute case is trickier because you need to remap the indexes if the signature changed

Copy link
Contributor Author

arsenm commented Mar 29, 2025

Merge activity

  • Mar 29, 5:10 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 29, 5:15 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 29, 5:17 AM EDT: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-callsite-attrs-operands-to-args branch from 181a168 to 6356a2d Compare March 29, 2025 09:12
Base automatically changed from users/arsenm/llvm-reduce/fix-losing-callsite-attrs-operands-to-args to main March 29, 2025 09:14
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-fmf-operands-to-args branch from 02186b9 to 0f3aa74 Compare March 29, 2025 09:14
@arsenm arsenm merged commit d3d4a24 into main Mar 29, 2025
6 of 11 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce/fix-losing-fmf-operands-to-args branch March 29, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants