Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-reduce: Fix losing operand bundles when removing arguments #133410

Merged
merged 1 commit into from
Mar 28, 2025
Merged

llvm-reduce: Fix losing operand bundles when removing arguments #133410

merged 1 commit into from
Mar 28, 2025

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 28, 2025

No description provided.

This was referenced Mar 28, 2025
Merged
Merged
Merged
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Mar 28, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 28, 2025
Merged
Merged
Merged
@arsenm arsenm marked this pull request as ready for review March 28, 2025 10:16
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments branch from d7da274 to 7e93188 Compare March 28, 2025 10:22
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-metadata-removing-arguments branch from 828f5b0 to 38d881a Compare March 28, 2025 10:22
This was referenced Mar 28, 2025
Merged
Merged
Merged
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-metadata-removing-arguments branch from 38d881a to 9013e6a Compare March 28, 2025 16:25
Base automatically changed from users/arsenm/llvm-reduce/fix-losing-metadata-removing-arguments to main March 28, 2025 16:28
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments branch from 7e93188 to 1e3bc8b Compare March 28, 2025 16:29
fhahn
fhahn approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

llvm/test/tools/llvm-reduce/remove-arguments-preserve-bundles.ll
%result = add i32 %call0, %call1
ret i32 %result
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments branch from 1e3bc8b to 3962ce4 Compare March 28, 2025 16:39
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Mar 28, 2025 •
edited
Loading

Merge activity

  • Mar 28, 12:39 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 28, 12:41 PM EDT: A user merged this pull request with Graphite.

@arsenm arsenm merged commit 6b1acdb into main Mar 28, 2025
6 of 9 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce/fix-losing-bundles-when-removing-arguments branch March 28, 2025 16:41
@arsenm arsenm mentioned this pull request Mar 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhahn fhahn fhahn approved these changes

@shiltian shiltian shiltian approved these changes

@aeubanks aeubanks Awaiting requested review from aeubanks

@jdoerfert jdoerfert Awaiting requested review from jdoerfert

@regehr regehr Awaiting requested review from regehr

Assignees
No one assigned
Labels
llvm-reduce
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arsenm @fhahn @shiltian