[clangd] Fix off-by-one error in CommandMangler #156593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SawInput() is intended to be called for every argument after a `--`, but it was mistakenly being called for the `--` itself. Partially fixes clangd/clangd#1850
HighCommander4
commented
Sep 3, 2025
| tooling::CompileCommand Cmd; | ||
| Cmd.CommandLine = {"clang-cl", "-std:c++latest", "--", "/Users/foo.cc"}; | ||
| Mangler(Cmd, "/Users/foo.cc"); | ||
| // Check that the -std:c++latest flag is not dropped |
There was a problem hiding this comment.
Not sure if this is the best test case for this change. -std:c++latest being dropped in transferCompileCommand() is a separate bug that will hopefully be fixed in the near future.
But I'm not sure how to write a more direct test for "transferCompileCommand() was not called", and the scenario being tested here is a valid one from a user expectation point of view.
|
Resubmitted as #160029. Will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SawInput() is intended to be called for every argument after a
--, but it was mistakenly being called for the--itself.Partially fixes clangd/clangd#1850