-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add beginner-focused office hours #80308
Conversation
I've also just added it to the LLVM Community Calendar (starting Feb 13): https://calendar.google.com/calendar/u/0/embed?src=calendar@llvm.org |
@@ -331,6 +331,11 @@ don't find anyone present, chances are they happen to be off that day. | |||
- Monthly, 4th Wednesday of the month at 9:30am PT, for 30 minutes. | |||
- `Google meet <https://meet.google.com/pdd-dibg-cwv>`__ | |||
- English | |||
* - Rotating hosts | |||
- Getting Started, beginner questions, new contributors. | |||
- Every Tuesday at 2 PM ET (11 AM PT), for 30 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using UTC; then it can be listed once (and everyone can do the conversion for their timezone from that).
7 PM UTC
would be the equivalent, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for a follow-up (not insisting on it, either!), convert all of the entries to specify their time in UTC but use a link to something like https://www.timeanddate.com/worldclock/converter.html?iso=20240201T180000&p1=136&p2=179&p3=224&p4=248 so that people have a better idea of when that is. It's not perfect thanks to stuff like daylight savings time changing throughout the year, but maybe there's a feature on that site (or one of the other ones) to account for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we do have a scheduling conflict due to daylight savings if the meeting moves from 2pm local time to 3pm local time in March for DST. Since (I think) all the current hosts have DST start and end on the same date, hopefully having the calendar event set based on ET is clear, and then when attendees view the LLVM calendar on the web (https://calendar.google.com/calendar/u/0/embed?src=calendar@llvm.org) it shows the corresponding UTC time accurately all year. If they add the LLVM calendar to their own calendar-ing app of choice (this is what I do), it should show all the meetings in their local time. Ack that none of the solutions are perfect because handwaves.
Likewise, I'll pass on the follow up only for those same reasons. I don't want to cause this document to conflict with the actual timezones people used for their calendar events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I notice there is confusion on the #beginners discord channel today about this exact problem. I will try to follow up with some documentation on this page for how to find these events in your local timezone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine for that work to be a follow-up after landing these changes, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together! LGTM, feel free to take or leave my comments.
@@ -331,6 +331,11 @@ don't find anyone present, chances are they happen to be off that day. | |||
- Monthly, 4th Wednesday of the month at 9:30am PT, for 30 minutes. | |||
- `Google meet <https://meet.google.com/pdd-dibg-cwv>`__ | |||
- English | |||
* - Rotating hosts | |||
- Getting Started, beginner questions, new contributors. | |||
- Every Tuesday at 2 PM ET (11 AM PT), for 30 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for a follow-up (not insisting on it, either!), convert all of the entries to specify their time in UTC but use a link to something like https://www.timeanddate.com/worldclock/converter.html?iso=20240201T180000&p1=136&p2=179&p3=224&p4=248 so that people have a better idea of when that is. It's not perfect thanks to stuff like daylight savings time changing throughout the year, but maybe there's a feature on that site (or one of the other ones) to account for that.
@@ -331,6 +331,11 @@ don't find anyone present, chances are they happen to be off that day. | |||
- Monthly, 4th Wednesday of the month at 9:30am PT, for 30 minutes. | |||
- `Google meet <https://meet.google.com/pdd-dibg-cwv>`__ | |||
- English | |||
* - Rotating hosts | |||
- Getting Started, beginner questions, new contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to specify the scope a bit more, like are these focused on LLVM, on Clang, how to use GitHub, or sort of all-of-the-above-plus-more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually hoping that intentionally vague could be a feature not a bug! For the newest contributors that might not know which of the above office hours or working groups would help them, I hope this might be a place we can answer very beginner questions or direct them towards the other available resources that are more specific to their issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that might be a feature after all then. I don't insist on a change. :-)
* llvm/main: (500 commits) [docs] Add beginner-focused office hours (llvm#80308) [mlir][sparse] external entry method wrapper for sparse tensors (llvm#80326) [StackSlotColoring] Ignore non-spill objects in RemoveDeadStores. (llvm#80242) [libc][stdbit] fix return types (llvm#80337) Revert "[RISCV] Refine cost on Min/Max reduction" (llvm#80340) [TTI]Add support for strided loads/stores. [analyzer][HTMLRewriter] Cache partial rewrite results. (llvm#80220) [flang][openacc][openmp] Use #0 from hlfir.declare value when generating bound ops (llvm#80317) [AArch64][PAC] Expand blend(reg, imm) operation in aarch64-pauth pass (llvm#74729) [SHT_LLVM_BB_ADDR_MAP][llvm-readobj] Implements llvm-readobj handling for PGOAnalysisMap. (llvm#79520) [libc] add bazel support for most of unistd (llvm#80078) [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-prefer-member-init (llvm#80330) [OpenMP] Fix typo (NFC) (llvm#80332) [BOLT] Enable re-writing of Linux kernel binary (llvm#80228) [BOLT] Adjust section sizes based on file offsets (llvm#80226) [libc] fix stdbit include test when not all entrypoints are available (llvm#80323) [RISCV][GISel] RegBank select and instruction select for vector G_ADD, G_SUB (llvm#74114) [RISCV] Add srmcfg CSR from Ssqosid extension. (llvm#79914) [mlir][sparse] add sparsification options to pretty print and debug s… (llvm#80205) [RISCV][MC] MC layer support for the experimental zalasr extension (llvm#79911) ...
These are initially being hosted by a rotating cast of: @danakj @gburgessiv @nickdesaulniers @sudonatalie
I think this is great, thank you for organizing this! One potential tweak that might be helpful, I'm not fully sure, would be to explicitly name the people who are the rotating hosts. My thinking there is that it might slightly lower the anxiety level for some newcomers when dialing in to these office hours, when they have an idea of who the host might be. |
These are initially being hosted by a rotating cast of: @danakj @gburgessiv @nickdesaulniers @sudonatalie