-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit mapping in labels + frontend improvements #137
Conversation
* explicit mapping in labels * Update frontend/components/traces/add-label.tsx Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to b45f8c4 in 1 minute and 7 seconds
More details
- Looked at
1242
lines of code in38
files - Skipped
1
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. frontend/components/dataset/dataset-panel.tsx:2
- Draft comment:
The import ofLoader
has been replaced withLoader2
fromlucide-react
. Ensure thatLoader2
is the intended icon and is available in thelucide-react
package. - Reason this comment was not posted:
Confidence changes required:50%
The import ofLoader
fromlucide-react
has been replaced withLoader2
across multiple files. This change is consistent and should be noted.
2. frontend/components/evaluator/evaluator-editor.tsx:174
- Draft comment:
ThevalueMap
is now an object instead of an array. Ensure that this change is consistent across the codebase and that all usages ofvalueMap
are updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The change from using an array forvalueMap
to using an object is significant and affects multiple files. This change should be consistent across the codebase.
3. frontend/components/traces/add-label-popover.tsx:388
- Draft comment:
ThevalueMap
is now an object instead of an array. Ensure that this change is consistent across the codebase and that all usages ofvalueMap
are updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The change from using an array forvalueMap
to using an object is significant and affects multiple files. This change should be consistent across the codebase.
4. frontend/components/traces/add-label.tsx:132
- Draft comment:
ThevalueMap
is now an object instead of an array. Ensure that this change is consistent across the codebase and that all usages ofvalueMap
are updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The change from using an array forvalueMap
to using an object is significant and affects multiple files. This change should be consistent across the codebase.
5. frontend/components/traces/span-labels.tsx:109
- Draft comment:
ThevalueMap
is now an object instead of an array. Ensure that this change is consistent across the codebase and that all usages ofvalueMap
are updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The change from using an array forvalueMap
to using an object is significant and affects multiple files. This change should be consistent across the codebase.
Workflow ID: wflow_qhYJcYl4bXW3pdN1
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
frontend/components/ui/formatter.tsx
Outdated
@@ -61,6 +63,14 @@ export default function Formatter({ | |||
return value; | |||
}; | |||
|
|||
const copyToClipboard = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functionality duplicates existing clipboard and toast operations found in project-api-keys.tsx
. Consider refactoring to use a common utility function.
- function
copyToClipboard
(project-api-keys.tsx)
{"label": numeric_val}
instead of an array and use of indexes.Important
This pull request updates label mapping to use explicit key-value pairs, enhances UI with a copy button and responsive design, updates loader icons, and adjusts CSS variables for consistency.
evaluator-editor.tsx
,add-label-popover.tsx
, andadd-label.tsx
.formatter.tsx
for copying formatted text.projects.tsx
.Loader
toLoader2
in multiple components includingdataset-panel.tsx
,dataset-upload.tsx
, anddelete-datapoints-dialog.tsx
.globals.css
for better visual consistency.next-auth
to version4.24.10
inpackage.json
.This description was created by for b45f8c4. It will automatically update as commits are pushed.