-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labeling queues #165
Merged
Merged
Labeling queues #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lift the restriction on data and target to be json objects * fix in dataset panel and zod schema
* upload images on consumer side of rabbitmq * Update app-server/src/language_model/chat_message.rs Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
* v0: write human eval data to queues as specified in client SDKs (#134) * v0: write human eval data to queues as specified in client SDKs * remove index in batch and insert one-by-one * cherry-pick some frontend updates from labeling_queue_ui to fix build * write executor span id to labeling queue * update the shape of labeling queue action slightly (#151) * update resultId in action to be in camelCase (#153) * labeling queues (#156) * updated table name --------- Co-authored-by: Dinmukhamed Mailibay <47117969+dinmukhamedm@users.noreply.github.com> Co-authored-by: Din <dinmukhamed.mailibay@gmail.com>
* batch insert labeling queue items, ignore non-existent queues * minor fix in comment * fix sync sleep
* insert human eval scores to clickhouse * don't setup env vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 6e4cc4e in 2 minutes and 26 seconds
More details
- Looked at
9119
lines of code in78
files - Skipped
1
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. frontend/lib/db/modifiers.ts:31
- Draft comment:
Consider handling cases wherefilter.value
is an array to support SQLIN
operations. This will ensure that filters with array values are correctly converted to SQL conditions. - Reason this comment was not posted:
Comment was on unchanged code.
2. frontend/lib/db/utils.ts:82
- Draft comment:
Ensure that removingbaseQuery
andbaseFilters
frompaginatedGet
does not break existing functionality that relied on these parameters for complex queries. - Reason this comment was not posted:
Comment did not seem useful.
3. frontend/lib/traces/types.ts:21
- Draft comment:
Ensure thatLabelClass
includes all necessary fields and that the types are correctly inferred from the database schema usingtypeof labelClasses.$inferSelect
. - Reason this comment was not posted:
Confidence changes required:50%
Infrontend/lib/traces/types.ts
, theLabelClass
type is defined usingtypeof labelClasses.$inferSelect
. This is a dynamic type inference from the database schema, which is a good practice for keeping types in sync with the database. However, it's important to ensure that all necessary fields are included and correctly typed.
4. frontend/lib/utils.ts:421
- Draft comment:
Ensure that JSON validation is handled appropriately elsewhere in the codebase, as theisJsonStringAValidObject
function has been removed. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_GdIZ0mXH1kWlJERm
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduces labeling queues feature with database schema updates, API routes, and frontend components, along with improvements to image processing and online evaluations.
labeling_queues
andlabeling_queue_items
tables inschema.ts
.Labels
andQueue
components for managing labeling queues in the frontend.spans
table to includeproject_id
inschema.ts
.datapoints
to allowtarget
to be nullable.datapoints_to_labeling_queues
function inutils.rs
for queue conversion.create_evaluation
inevaluations.rs
to handle labeling queues.storage
parameter from several functions intraces
module.datasets
andevaluations
API routes to use new schema paths.CreateQueueDialog
andQueues
components for managing queues.AddLabel
component to support evaluator and label value pairs.paginatedGet
function inutils.ts
to simplify query logic.This description was created by for 6e4cc4e. It will automatically update as commits are pushed.