improve UI for workspaces + internal fixes #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporarily rename the CH table to old_evaluation_results
query table evaluation_results with timestamp
update evaluation table schema
* fix some migrations
* Migrate get evaluations query to Drizzle on API Frontend * Change code to follow some feedbacks * add with query get evaluation result * delete some unused code * refac: move calling db to page file from api route * delete unuse code on auth checking --------- Co-authored-by: Vidya Haikal <vidya.haikal@hukumonline.com> Co-authored-by: Dinmukhamed Mailibay <47117969+dinmukhamedm@users.noreply.github.com>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ee7dee6 in 59 seconds
More details
- Looked at
931lines of code in22files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. app-server/src/routes/evaluations.rs:96
- Draft comment:
Usingunwrap()aftertry_join!is unnecessary and can lead to panics if the result is an error. Consider using pattern matching to handle the result more gracefully. - Reason this comment was not posted:
Comment was on unchanged code.
2. frontend/app/api/projects/[projectId]/evaluations/[evaluationId]/route.ts:28
- Draft comment:
Ensure thatjsonb_object_aggis supported by the database being used, as it is a PostgreSQL-specific function. If not, consider replacing it with an equivalent function. - Reason this comment was not posted:
Comment did not seem useful.
3. frontend/app/project/[projectId]/evaluations/[evaluationId]/page.tsx:57
- Draft comment:
Ensure thatjsonb_object_aggis supported by the database being used, as it is a PostgreSQL-specific function. If not, consider replacing it with an equivalent function. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_igaKF9YjIgEZA4er
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Improved workspace UI, added timestamps to evaluation scores, and migrated evaluation queries to Drizzle with database schema updates.
workspace/page.tsx,projects.tsx, andworkspaces-navbar.tsx.project-card.tsxfor better project display.button.tsx.evaluation_scoresinevaluation_scores.rsand001000-initial.sql.get_evaluation_datapointfromevaluations.rsandmain.rs.route.tsandpage.tsx.evaluation_scorestable schema in001000-initial.sql.0004_worthless_kitty_pryde.sql.0002_snapshot.jsonand0003_snapshot.json.This description was created by
for ee7dee6. It will automatically update as commits are pushed.