Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: response model would overwrite request model #238

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Nov 22, 2024

Important

Fix incorrect model usage in get_llm_usage_for_span in utils.rs and correct a typo in attributes.rs.

  • Behavior:
    • Fix get_llm_usage_for_span in utils.rs to correctly use response_model instead of request_model for response calculations.
  • Misc:
    • Fix typo in comment in attributes.rs.

This description was created by Ellipsis for b6e8384. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b6e8384 in 18 seconds

More details
  • Looked at 35 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. app-server/src/traces/utils.rs:81
  • Draft comment:
    The change from request_model to response_model is correct and fixes the bug where the response model was incorrectly set to the request model.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR fixes a bug where the response model was incorrectly set to the request model. The change is correct and aligns with the intended functionality.

Workflow ID: wflow_pJxRKCbAiMTEuX1c


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit b6e3e92 into dev Nov 22, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the fix/span-attr branch November 22, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant