Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: response model would overwrite request model #238

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: response model would overwrite request model #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app-server/src/traces/attributes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use std::collections::HashMap;

use chrono::{DateTime, Utc};
use serde_json::Value;
use uuid::Uuid;

use crate::db::trace::TraceType;
Expand All @@ -17,7 +16,7 @@ pub struct TraceAttributes {
pub total_token_count: Option<i64>,
pub input_cost: Option<f64>,
pub output_cost: Option<f64>,
/// Total costis not calculated on this struct and must be set manually
/// Total cost is not calculated on this struct and must be set manually
pub cost: Option<f64>,
pub session_id: Option<String>,
pub trace_type: Option<TraceType>,
Expand Down
2 changes: 1 addition & 1 deletion app-server/src/traces/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ pub async fn get_llm_usage_for_span(
input_cost,
output_cost,
total_cost,
response_model: attributes.request_model().clone(),
response_model: attributes.response_model().clone(),
request_model: attributes.request_model().clone(),
provider_name,
}
Expand Down