transient keys for signing invoice requests #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 105 105
======================================
Misses 105 105 ☔ View full report in Codecov by Sentry. |
dunxen
reviewed
Aug 11, 2024
| @@ -590,7 +590,7 @@ impl InvoicePayer for Client { | |||
|
|
|||
| let blinded_payment_paths = tonic_lnd::lnrpc::BlindedPaymentPath { | |||
| blinded_path, | |||
| total_cltv_delta: u32::from(cltv_expiry_delta) + 120, | |||
There was a problem hiding this comment.
What was the context for this extra delta before?
There was a problem hiding this comment.
IIRC in earlier versions of our fork of ldk-sample, payments wouldn't work without this addition. I think I got the exact number from the notes in Carla's PR here: lightningnetwork/lnd#7267 But I think CLN doesn't like this additional delta & newer version of LDK don't need it. I'll add a comment to the commit for more clarification.
orbitalturtle
force-pushed
the
transient-keys-2
branch
from
6cb8a75 to
30ec757
Compare
We should use a new key to sign each invoice request to improve sender privacy and to ensure we can pay a particular CLN offer more than once.
In earlier versions of ldk-sample we couldn't make a payment without this additional delta. But CLN doesn't like this additional delta and it's no longer necessary for payments to ldk-sample.
orbitalturtle
force-pushed
the
transient-keys-2
branch
from
30ec757 to
b1047ed
Compare
|
@dunxen Thanks for the review as always! Just pushed up those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use a new key to sign each invoice request to improve sender privacy. Closes #116