Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transient keys for signing invoice requests #133

Merged
merged 2 commits into from
Aug 13, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
offers: remove extra cltv expiry delta
In earlier versions of ldk-sample we couldn't make a payment without this
additional delta. But CLN doesn't like this additional delta and it's no longer
necessary for payments to ldk-sample.
  • Loading branch information
orbitalturtle committed Aug 13, 2024
commit b1047ed860d4fc0ebd6f00591cf616e5e801d56c
2 changes: 1 addition & 1 deletion src/lndk_offers.rs
Original file line number Diff line number Diff line change
@@ -603,7 +603,7 @@ impl InvoicePayer for Client {

let blinded_payment_paths = tonic_lnd::lnrpc::BlindedPaymentPath {
blinded_path,
total_cltv_delta: u32::from(cltv_expiry_delta) + 120,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the context for this extra delta before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC in earlier versions of our fork of ldk-sample, payments wouldn't work without this addition. I think I got the exact number from the notes in Carla's PR here: lightningnetwork/lnd#7267 But I think CLN doesn't like this additional delta & newer version of LDK don't need it. I'll add a comment to the commit for more clarification.

total_cltv_delta: u32::from(cltv_expiry_delta),
base_fee_msat: u64::from(fee_base_msat),
proportional_fee_msat: u64::from(fee_ppm),
..Default::default()
Loading