Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› fix: Update zhipu param limit #3347

Closed
wants to merge 12 commits into from
Closed

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented Jul 28, 2024 โ€ข

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • โšก๏ธ perf
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

ๆ นๆฎๆœ€ๆ–ฐๆ–‡ๆกฃ๏ผŒๆ›ดๆ”นไบ†ไธๅŒๆจกๅž‹ๅ…่ฎธ็š„ temperature ไธŽ top_p ่Œƒๅ›ดใ€‚

็›ธๅ…ณ #3355

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

https://open.bigmodel.cn/dev/api#glm-4

Sorry, something went wrong.

Verified

This commit was signed with the committerโ€™s verified signature.
rouault Even Rouault
Copy link

vercel bot commented Jul 28, 2024

@sxjeru is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

๐Ÿ‘ @sxjeru

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

sxjeru added 2 commits July 28, 2024 12:29
Copy link

codecov bot commented Jul 28, 2024 โ€ข

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.05%. Comparing base (0cfee6b) to head (6e661c5).
Report is 318 commits behind head on main.

Files with missing lines Patch % Lines
src/libs/agent-runtime/zhipu/index.ts 46.15% 7 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3347      +/-   ##
==========================================
- Coverage   92.07%   92.05%   -0.03%     
==========================================
  Files         460      460              
  Lines       31542    31549       +7     
  Branches     2999     3148     +149     
==========================================
  Hits        29043    29043              
- Misses       2499     2506       +7     
Flag Coverage ฮ”
app 92.05% <46.15%> (-0.03%) โฌ‡๏ธ
server 97.36% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

sxjeru added 7 commits July 28, 2024 19:48
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 7, 2024
@arvinxx
Copy link
Contributor

arvinxx commented Sep 9, 2024

่ฟ™ไธชๅพ—่กฅไธ‹ไธๅŒๆจกๅž‹็š„ๅ•ๆต‹

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


This needs to be supplemented by single tests of different models.

@arvinxx
Copy link
Contributor

arvinxx commented Oct 28, 2024

zhipu ็š„ๅฎž็Žฐไน‹ๅ‰ๅš่ฟ‡ไธ€่ฝฎ้‡ๆž„ไบ†๏ผŒไผผไนŽ่ฟ™ไธชไธ้œ€่ฆไบ†

@arvinxx arvinxx closed this Oct 28, 2024
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


The implementation of zhipu has undergone a round of reconstruction before, and it seems that this is no longer needed.

@sxjeru sxjeru deleted the patch-4 branch October 28, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants