Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Update zhipu param process #4523

Merged
merged 5 commits into from
Oct 29, 2024
Merged

🐛 fix: Update zhipu param process #4523

merged 5 commits into from
Oct 29, 2024

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented Oct 28, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

更新自 #3347

其中的模型参数限制都在文档中注明了。

https://open.bigmodel.cn/dev/api/intelligent-agent-model/glm-4-alltools
https://open.bigmodel.cn/dev/api/normal-model/glm-4

📝 补充信息 | Additional Information

为什么现在使用一切正常?因为 do_sample 参数把本地设置的 temperature 和 top_p 全部忽略了,当然不会报错。

已一并去除。

Copy link

vercel bot commented Oct 28, 2024

@sxjeru is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @sxjeru

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.29%. Comparing base (30b424a) to head (45b089f).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/libs/agent-runtime/zhipu/index.ts 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4523      +/-   ##
==========================================
- Coverage   92.30%   92.29%   -0.02%     
==========================================
  Files         498      498              
  Lines       36238    36255      +17     
  Branches     3294     2338     -956     
==========================================
+ Hits        33451    33463      +12     
- Misses       2787     2792       +5     
Flag Coverage Δ
app 92.29% <80.00%> (-0.02%) ⬇️
server 97.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sxjeru sxjeru marked this pull request as ready for review October 28, 2024 04:57
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐛 Bug Something isn't working | 缺陷 labels Oct 28, 2024
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@arvinxx arvinxx merged commit 3317fbd into lobehub:main Oct 29, 2024
4 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @sxjeru ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
### [Version&nbsp;1.26.8](v1.26.7...v1.26.8)
<sup>Released on **2024-10-29**</sup>

#### 🐛 Bug Fixes

- **misc**: Update zhipu param process.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Update zhipu param process, closes [#4523](#4523) ([3317fbd](3317fbd))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.26.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Oct 29, 2024
### [Version&nbsp;1.69.4](v1.69.3...v1.69.4)
<sup>Released on **2024-10-29**</sup>

#### 🐛 Bug Fixes

- **misc**: Update zhipu param process.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Update zhipu param process, closes [lobehub#4523](https://github.com/bentwnghk/lobe-chat/issues/4523) ([3317fbd](3317fbd))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@sxjeru sxjeru deleted the patch-1 branch November 16, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants