Skip to content

Commit

Permalink
Merge pull request #33 from localgovdrupal/fix/php8.3/drupal-function…
Browse files Browse the repository at this point in the history
…al-tests

[PHP 8.3] ci: change chromedriver image to fix functional javascript tests
  • Loading branch information
finnlewis authored Jul 1, 2024
2 parents c580cc4 + 0653f00 commit 8aea249
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ jobs:
- name: Create LocalGov Drupal project
run: composer create-project --stability dev localgovdrupal/localgov-project ./html "${{ matrix.localgov-version }}"

- name: Obtain all dev dependencies for LocalGov Drupal
run: jq --raw-output '.packages[] | select(.name | startswith("localgovdrupal/")) | ."require-dev" | values | to_entries[] | @sh "\(.key):\(.value)"' ./html/composer.lock | sort | uniq | xargs composer --working-dir=./html require --dev --no-interaction

- name: Start Docker environment
run: docker-compose up -d

Expand Down
19 changes: 13 additions & 6 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ services:
environment:
SIMPLETEST_BASE_URL: 'http://drupal'
SIMPLETEST_DB: 'mysql://database:database@database/database'
MINK_DRIVER_ARGS_WEBDRIVER: '["chrome", { "chromeOptions": { "w3c": false } }, "http://chromedriver:4444/wd/hub"]'
MINK_DRIVER_ARGS_WEBDRIVER: '["chrome", {"browserName": "chrome", "goog:chromeOptions": {"args": ["--disable-gpu","--headless", "--no-sandbox", "--disable-dev-shm-usage"]}}, "http://chromedriver:9515"]'
SYMFONY_DEPRECATIONS_HELPER: weak
extra_hosts:
- "group-a1.drupal:127.0.0.1"
Expand Down Expand Up @@ -50,11 +50,18 @@ services:
retries: 100

chromedriver:
image: selenium/standalone-chrome:106.0
image: drupalci/webdriver-chromedriver:production
container_name: chromedriver
environment:
START_XVBF: 'false'
ulimits:
core:
soft: -1
hard: -1
ports:
- "4444:4444"
volumes:
- /dev/shm:/dev/shm
- "9515:9515"
entrypoint:
- chromedriver
- "--log-path=/tmp/chromedriver.log"
- "--verbose"
- "--allowed-ips="
- "--allowed-origins=*"

0 comments on commit 8aea249

Please sign in to comment.