Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.3] ci: change chromedriver image to fix functional javascript tests #33

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

millnut
Copy link
Member

@millnut millnut commented Jun 25, 2024

Fixes functional testing on the workflows due to a change in Drupal 10.3 and requiring changes to the chromedriver image we use in drupal-container, more info localgovdrupal/localgov_elections#47 (comment)

Once merged we need to push a docker image update

Tests now work correctly and the bulk of the remaining errors are below, this was initially run with phpunit as paratest hides things :( you can see the full output here https://github.com/localgovdrupal/drupal-container/actions/runs/9685204693/job/26724752057

2024-06-26T19:38:38.5315284Z 1) Drupal\Tests\localgov_content_lock\Functional\ContentLockTest::testContentLockConfiguration
2024-06-26T19:38:38.5320086Z Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for system.cron with the following errors: system.cron:logging variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData
2024-06-26T19:38:38.5322026Z 
2024-06-26T19:38:38.5322736Z /var/www/html/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
2024-06-26T19:38:38.5324457Z /var/www/html/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111
2024-06-26T19:38:38.5325885Z /var/www/html/web/core/lib/Drupal/Core/Config/Config.php:230
2024-06-26T19:38:38.5326980Z /var/www/html/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:396
2024-06-26T19:38:38.5328506Z /var/www/html/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
2024-06-26T19:38:38.5329831Z /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
2024-06-26T19:38:38.5331181Z /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:326
2024-06-26T19:38:38.5332522Z /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
2024-06-26T19:38:38.5333621Z /var/www/html/web/core/includes/install.inc:567
2024-06-26T19:38:38.5334364Z /var/www/html/web/core/includes/install.core.inc:1125
2024-06-26T19:38:38.5335167Z /var/www/html/web/core/includes/install.core.inc:695
2024-06-26T19:38:38.5335951Z /var/www/html/web/core/includes/install.core.inc:572
2024-06-26T19:38:38.5336733Z /var/www/html/web/core/includes/install.core.inc:122
2024-06-26T19:38:38.5337787Z /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
2024-06-26T19:38:38.5339227Z /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:570
2024-06-26T19:38:38.5340335Z /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
2024-06-26T19:38:38.5342279Z /var/www/html/web/profiles/contrib/localgov/modules/localgov_content_lock/tests/src/Functional/ContentLockTest.php:33
2024-06-26T19:38:38.5343920Z /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

@millnut millnut changed the title ci: change chromedriver image [PHP 8.3] ci: change chromedriver image Jun 26, 2024
@millnut millnut changed the title [PHP 8.3] ci: change chromedriver image [PHP 8.3] ci: change chromedriver image to fix functional javascript tests Jun 26, 2024
@millnut millnut requested review from stephen-cox and finnlewis June 26, 2024 19:55
@millnut millnut marked this pull request as ready for review June 26, 2024 19:55
@finnlewis finnlewis merged commit 8aea249 into php8.3 Jul 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants