Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables admin_role module #749

Merged
merged 2 commits into from
Sep 17, 2024
Merged

enables admin_role module #749

merged 2 commits into from
Sep 17, 2024

Conversation

markconroy
Copy link
Member

Closes #748

What does this change?

Enables the new localgov_admin_role module, so we have a consistent way of working with an admin role.

How to test

Install the distro, check that there is now an 'Admin' role and that is set to be the role used for the administrator role.


Thanks to Big Blue Door for sponsoring my time to work on this.

Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on localgovdrupal/localgov_core#238 first.

The required version will also need bumping in composer.json so that the module does exist before it tries to install it.

@andybroomfield
Copy link
Contributor

I'm getting the following error about missing the localgov_admin_role module, which is becuase I have a different branch of localgov_core checked out, but this reminds us that we should now bump up the minimum version of localgov_core in the profile to make sure the sub module it there.

Required modules:Required modules not found.<br /><br />The following modules are required but were not found. Move them into the appropriate modules subdirectory, such as <em>/modules</em>. Missing modules:   
                                                                                                                                                                                                                    
  <!-- THEME DEBUG -->                                                                                                                                                                                              
  <!-- THEME HOOK: 'item_list' -->                                                                                                                                                                                  
  <!-- 💡 BEGIN CUSTOM TEMPLATE OUTPUT from 'core/themes/claro/templates/classy/dataset/item-list.html.twig' -->                                                                                                    
  <div class="item-list--comma-list item-list"><ul class="item-list__comma-list"><li><span class="admin-missing">Localgov_admin_role</span></li></ul></div>                                                         
  <!-- END CUSTOM TEMPLATE OUTPUT from 'core/themes/claro/templates/classy/dataset/item-list.html.twig' -->         

Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This installed the admin role and I could create an administrator and log in as such and perform admin actions.

Screenshot 2024-08-09 at 11 32 07 AM

Note: This required me to be on latest 2.x of localgov_core, as the admin role is not yet included in a release.

Thought: Maybe just rename the role label as Administrator, keep localgov_admin as the internal machine name.

Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We can get this merged and released now the module as been released as part of LGD Core

@markconroy
Copy link
Member Author

@ekes you requested changes in this. Is it okay for you now? Or is there more to do?

@finnlewis finnlewis merged commit 0d19a7c into 3.x Sep 17, 2024
8 checks passed
@finnlewis finnlewis deleted the feature/748/enable-admin-role branch September 17, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable localgov_admin by default
5 participants