Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds admin role module #234

Merged
merged 5 commits into from
Jul 30, 2024
Merged

adds admin role module #234

merged 5 commits into from
Jul 30, 2024

Conversation

markconroy
Copy link
Member

Adds a module to set an admin role.

Thanks to Big Blue Door for sponsoring my time to work on this.

@markconroy markconroy self-assigned this Jul 16, 2024
@markconroy markconroy mentioned this pull request Jul 16, 2024
Closed
stephen-cox
stephen-cox reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach is fine. Just one suggestion on using a class constant for the role name rather than a string.

modules/localgov_admin_role/localgov_admin_role.install Outdated Show resolved Hide resolved
@markconroy markconroy mentioned this pull request Jul 30, 2024
Closed
@markconroy
Copy link
Member Author

Follow up issue to enable this module by default: localgovdrupal/localgov#749

@ekes ekes merged commit c8d377c into 2.x Jul 30, 2024
8 checks passed
@rupertj rupertj mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-cox stephen-cox stephen-cox left review comments

@finnlewis finnlewis Awaiting requested review from finnlewis

@andybroomfield andybroomfield Awaiting requested review from andybroomfield

Assignees

@markconroy markconroy

Labels
None yet
Projects
2024 Mission: Editor experience
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markconroy @stephen-cox @ekes