Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add docker build and publish action #3

Merged
merged 2 commits into from
Oct 21, 2022
Merged

ci: add docker build and publish action #3

merged 2 commits into from
Oct 21, 2022

Conversation

HarshCasper
Copy link
Member

No description provided.

@HarshCasper
Copy link
Member Author

@whummer
Copy link
Member

whummer commented Oct 19, 2022

@HarshCasper do you want to move the contents of LocalStack folder into the top level, as we discussed yesterday? /cc @Pive01

@HarshCasper
Copy link
Member Author

@HarshCasper do you want to move the contents of LocalStack folder into the top level, as we discussed yesterday? /cc @Pive01

I believe yes. @Pive01 if you wish to push in any further commits of your work, please do so. I will move the contents of LocalStack dir in top level soon after 👍

@Pive01
Copy link
Collaborator

Pive01 commented Oct 19, 2022

@HarshCasper do you want to move the contents of LocalStack folder into the top level, as we discussed yesterday? /cc @Pive01

I believe yes. @Pive01 if you wish to push in any further commits of your work, please do so. I will move the contents of LocalStack dir in top level soon after +1

Actually, I just made a PR where I did that ( #4 ), I also mentioned a couple of things still pending before officially presenting the extension like the persistence part (it seems that localstorage is not persistent after all) that needs to be solved @HarshCasper

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configured the Docker credentials in the build environment - will merge the PR, to test the Docker push. 👍

As a next step, we can reconfigure the pipeline to only push the Docker image for builds on main branch. /cc @HarshCasper

@whummer whummer merged commit fa7019a into main Oct 21, 2022
@whummer whummer deleted the ci/cd branch October 21, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants