UI and files hierarchy changes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Looks great @Pive01 🚀 - added a few minor comment, but nothing that should block the merge.
Merging this now, so we can get a first version out soon together with @HarshCasper . Looking forward to seeing this in action! 🎉
/cc @lukqw
| }; | ||
|
|
||
| const stop = async () => { | ||
| ddClient.docker.cli.exec('run', STOP_ARGS).then(() => mutate()); |
There was a problem hiding this comment.
nit: if we use async functions, we could use await here, rather than Thenable chaining.
|
|
||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
nit: <> wrapper probably not required here.. (as it contains only a single <Card ..> element)
| @@ -11,6 +11,8 @@ const COMMON_ARGS = [ | |||
| export const START_ARGS = [ | |||
| '-e', | |||
| 'LOCALSTACK_VOLUME_DIR=/tmp', | |||
| '-e', | |||
There was a problem hiding this comment.
We should probably make this additional EXTRA_CORS_ALLOWED_ORIGINS setting part of a dev config. Not critical for now - can look into that in a future iteration. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Content
TODO