Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
GeoTrellis uses
com.typesafe.scalalogging
package. This is a popular library but unfortunately theLazyLogging
trait that is used to mix-in a logger has shifted around a number of timers through the version history. This causes frequent binary incompatibility problems.This PR removes any mention of
LazyLogging
trait and replaces it withprotected lazy val logger: Logger
fields. TheLogger
class is a little more stable.Additionally:
Checklist
docs/CHANGELOG.rst
updated, if necessary[ ]docs
guides update, if necessary[ ] New user API has useful Scaladoc strings[ ] Unit tests added for bug-fix or new feature