Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to log4s #3116

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Switch to log4s #3116

merged 2 commits into from
Oct 7, 2019

Conversation

echeipesh
Copy link
Contributor

Overview

GeoTrellis uses com.typesafe.scalalogging package. This is a popular library but unfortunately the LazyLogging trait that is used to mix-in a logger has shifted around a number of timers through the version history. This causes frequent binary incompatibility problems.

This PR removes dependency on typesafe-scalalogging in favor of log4s and moves all logging to private members to minimize their leakage.

Hopefully this will help us with conflicts and add some nice features to our logging.

Additionally:
GeoWave/GeoMesa do not log errors with experimental notice

@echeipesh
Copy link
Contributor Author

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what buys me in this library, that the syntax to create an instance of a new logger is just shorter (one func call with no parameters vs logger instance creation + wrapping it into scala wrapper).

Once CQ would be done, merging!

@pomadchin pomadchin mentioned this pull request Oct 7, 2019
1 task
@pomadchin pomadchin removed the needs cq label Oct 7, 2019
@pomadchin
Copy link
Member

Resolves #3114 but for the master branch.

@pomadchin pomadchin merged commit 7eb7958 into locationtech:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants