-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for SparkML memory pressure issues #344
Conversation
rather than methods.
…ory pressure. Reworked TileExplodeBench
@@ -293,3 +296,12 @@ trait StandardSerializers { | |||
implicit val spaceTimeKeyTLMSerializer = tileLayerMetadataSerializer[SpaceTimeKey] | |||
|
|||
} | |||
|
|||
object StandardSerializers { | |||
private val s2ctCache = Scaffeine().build[String, CellType]( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no... :D Have you figured out a proper fix for geotrellis-core? we could back port a proper fix into the 2.x branch and release it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pomadchin This is just temporary for now. I'll submit a PR to GeoTrellis as soon as I can.... but our team needed a quick fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Do you have jmh results from running TileExplodeBench before/after? Would be interested to see those on the ticket #343 or on this PR just for reference. Curious how much difference from the changes in ExplodeTiles ...
@vpipkt I'm really sorry but I accidentally did a |
Fixed SparkML memory pressure issue caused by unnecessary reevaluation, overallocation, and primitive boxing.
Closes #343