Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SparkML memory pressure issues #344

Merged
merged 4 commits into from
Sep 13, 2019
Merged

Conversation

metasim
Copy link
Member

@metasim metasim commented Sep 13, 2019

Fixed SparkML memory pressure issue caused by unnecessary reevaluation, overallocation, and primitive boxing.

Closes #343

@metasim metasim requested a review from vpipkt September 13, 2019 13:22
@@ -293,3 +296,12 @@ trait StandardSerializers {
implicit val spaceTimeKeyTLMSerializer = tileLayerMetadataSerializer[SpaceTimeKey]

}

object StandardSerializers {
private val s2ctCache = Scaffeine().build[String, CellType](
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no... :D Have you figured out a proper fix for geotrellis-core? we could back port a proper fix into the 2.x branch and release it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pomadchin This is just temporary for now. I'll submit a PR to GeoTrellis as soon as I can.... but our team needed a quick fix.

Copy link
Member

@vpipkt vpipkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Do you have jmh results from running TileExplodeBench before/after? Would be interested to see those on the ticket #343 or on this PR just for reference. Curious how much difference from the changes in ExplodeTiles ...

@metasim
Copy link
Member Author

metasim commented Sep 13, 2019

@vpipkt I'm really sorry but I accidentally did a clean and killed off the ExplodeTiles stats. They weren't hugely different... < 10%? But the improvement may have other benefits depending the spark.sql.tungsten.enabled setting.

@metasim metasim merged commit d183c81 into locationtech:develop Sep 13, 2019
@metasim metasim deleted the fix/343 branch September 16, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CellType reification is overly slow and memory intensive
3 participants