Fixed Exception swallowing in RasterSource. #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpipkt
suggested changes
Sep 13, 2019
There was a problem hiding this comment.
small change below bout the error message itself...
I also see that we have a possibly unstable result or regression in one of the unrelated python tests (only on Circle). I think unrelated, passes on Travis and locally. I will try to chip in there.
But overall good times. This is what i see in Notebook cell results when feeding a bad URI into a catalog:
Py4JJavaError: An error occurred while calling o87.showString.
: org.apache.spark.SparkException: Job aborted due to stage failure: Task 2 in stage 1.0 failed 1 times, most recent failure: Lost task 2.0 in stage 1.0 (TID 3, localhost, executor driver): java.lang.IllegalArgumentException: GDALRasterSource(https://modis-pds.s3.amazonaws.com/MCD43A4.006/11/08/2019059/MCD43A4.A2019059.h11v08.006.2019072203257_B02.TIF), GDALRasterSource(https://modis-pds.s3.amazonaws.com/MCD43A4.006/11/08/2019059/MCD43A4.A2019059.h11v08.006.201907229999_B02.TIF)
at org.locationtech.rasterframes.expressions.generators.RasterSourceToRasterRefs.eval(RasterSourceToRasterRefs.scala:81)
...in/scala/org/locationtech/rasterframes/expressions/generators/RasterSourceToRasterRefs.scala
Outdated
Show resolved
Hide resolved
…table Signed-off-by: Jason T. Brown <jason@astraea.earth>
* commit 'd183c815168fa31488068314104aacf87cfdabe6':
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #344 .
Fixes #267