[python/multibody] fix include order in frames.cpp #1150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
We've noticed a compilation issue under pinocchio 3x: on devel, we're getting the following compiler error (or a variation of it, repeated a few times):
(The compiler is Clang 15, but the same happens on GCC 13, AFAIK).
The struct it's referring to is the template struct
pinocchio::NumericalBase
from Pinocchio's fwd header but obviously the compiler can't see it.The Pinocchio bindings'
bindings/utils/std-aligned-vector.hpp
header (or evenstd-vector.hpp
) needs to be included after the Pinocchio fwd header which defines the struct. I think these headers maybe used to include<pinocchio/fwd.hpp>
before but I'm not sure. The include order before the change looks a bit odd though: maybe the pre-commit bot reordered the includes by alphabetical order?