Fix Windows build #144
Merged
Fix Windows build #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisv
commented
Dec 20, 2024
•
jorisv
commented
- clang-cl build
- cl build
- Fix TU
- CI
jorisv
force-pushed
the
topic/windows
branch
2 times, most recently
from
7e23916 to
5e83807
Compare
jorisv
force-pushed
the
topic/windows
branch
from
450df69 to
d5b8ca2
Compare
|
I have test on Windows with clang and clang-cl. There is two tests that are not working right now:
@nim65s Do you think the pip workflow can work on Windows ? |
|
cmeel does not support windows, because I have no idea how this platform is supposed to work :/ |
|
Ok, I can add a conda/pixi workflow if you think it's worth it. |
|
It's up to you :) |
jorisv
force-pushed
the
topic/windows
branch
3 times, most recently
from
196b01f to
2e61205
Compare
jorisv
force-pushed
the
topic/windows
branch
6 times, most recently
from
beebc0a to
67f5814
Compare
cmake: Don't filter define
tests: uninit value
tests: uninit value
jorisv
force-pushed
the
topic/windows
branch
from
67f5814 to
b5197a8
Compare
|
It's all good. |
nim65s
reviewed
Dec 31, 2024
Co-authored-by: Guilhem Saurel <guilhem.saurel@laas.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.